Fix tidy with maintain_stored_certificate_counts == publish_stored_certificate_count_metrics == false #20664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rtificate_count_metrics == false The logic around the check to set both to false was wrong, and should be validated independently. Additionally, these fields should only exist on auto-tidy and not on the manual tidy endpoint. Signed-off-by: Alexander Scheel <[email protected]>
cipherboy
requested review from
kitography,
stevendpclark,
hellobontempo and
a team
stevendpclark
approved these changes
May 18, 2023
Co-authored-by: claire bontempo <[email protected]>
Signed-off-by: Alexander Scheel <[email protected]>
This was referenced May 19, 2023
cipherboy
added a commit
that referenced
this pull request
May 19, 2023
Fix tidy with maintain_stored_certificate_counts == publish_stored_certificate_count_metrics == false (#20664) * Fix tidy with maintain_stored_certificate_counts == publish_stored_certificate_count_metrics == false The logic around the check to set both to false was wrong, and should be validated independently. Additionally, these fields should only exist on auto-tidy and not on the manual tidy endpoint. Signed-off-by: Alexander Scheel <[email protected]> * Update builtin/logical/pki/path_tidy.go Co-authored-by: claire bontempo <[email protected]> --------- Signed-off-by: Alexander Scheel <[email protected]> Co-authored-by: claire bontempo <[email protected]> Signed-off-by: Alexander Scheel <[email protected]>
This was referenced Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic around the check to set both to false was wrong, and should be validated independently.
Additionally, these fields should only exist on auto-tidy and not on the manual tidy endpoint.